This repository was archived by the owner on Aug 1, 2023. It is now read-only.
Conversation
ghost
assigned
jacobheun
force-pushed
the
test/pnet
branch
2 times, most recently
from
b7f5906 to
ab26a4e
Compare
test: add skips for tests that timeout test: add additional pnet tests temporarily use a temp branch of pull-reader for testing test: add test for go getting data from js test: add tests for go to go test: check pnet peers after attempted connections test: update order of operations to avoid timeouts from go
Member
|
@jacobheun can you take these to the finish line in the foreseeable future? |
daviddias
changed the title
Contributor
Author
|
@daviddias yes! I updated the blocking PR in ipfs-repo if you can take a look ipfs/js-ipfs-repo#172. There were concerns there about not using the keychain, but the spec isn't written to support using the keychain. |
daviddias
added
the
status/blocked
achingbrain
force-pushed
the
master
branch
3 times, most recently
from
94b26b7 to
f4c783a
Compare
achingbrain
force-pushed
the
master
branch
2 times, most recently
from
e2cb915 to
b006606
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This depends on libp2p/js-libp2p-pnet#1 and its subsequent release into libp2p.
I created this to provide visibility into the existing interop tests while those all get merged and released.
Currently the only running tests are for js to js and js to go on the same private network. There is currently an issue in pull-reader with a private node attempts to talk with an invalid node (public or with a different key) that causes the initial connection to hang until it times out. I've added comments above the skips pointing to the issue. Rather than leave in tests that timeout, I've skipped them until we're able to error the connection out timely.